Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken relative imports for proto output types generation #555

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Dimitrioglo
Copy link

@Dimitrioglo Dimitrioglo commented Jan 31, 2024

Summary

  • Fixed broken relative imports for output types generation
  • Added possibility to generate interfaces for folder containing subfolders of .proto files
  • Refactored get_directories to return only first-level directories
  • Covered with the tests case when imports can be not generated

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue. #472 #441
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Dimitrioglo Dimitrioglo force-pushed the fix/broken-output-types-generation branch from 8bef2b8 to 2dd20e3 Compare January 31, 2024 20:57
@Dimitrioglo
Copy link
Author

Can you check please? @danielgtaylor, @Gobot1234

@Gobot1234
Copy link
Collaborator

Please can you add a test for this case?

@Dimitrioglo
Copy link
Author

Dimitrioglo commented Feb 17, 2024

Please can you add a test for this case?

Done, can you check?

@Gobot1234 @danielgtaylor

@Dimitrioglo
Copy link
Author

@Gobot1234 Can you process with review?

@Gobot1234
Copy link
Collaborator

Please can you run the code through black

@Dimitrioglo
Copy link
Author

@Gobot1234 fixed pre-commit hooks issues

@Dimitrioglo
Copy link
Author

@Gobot1234 is any chance this fix will be released in next weeks/month?

@Dimitrioglo
Copy link
Author

@Gobot1234 , @danielgtaylor Any news guys?

tests/util.py Outdated Show resolved Hide resolved
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
@Gobot1234
Copy link
Collaborator

Not sure why linux CI is failing

@mohd-saaduddin-ansari
Copy link

Hi @danielgtaylor , i am also facing the broken relative imports issue. when can we merge this PR ?

@Gobot1234
Copy link
Collaborator

It will be merged when the CI is fixed

@Gobot1234 Gobot1234 self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants