Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed: update VerifyingKey::from_bytes with ZIP-215 info #704

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tarcieri
Copy link
Contributor

Removes the previous warning that points are unvalidated: they're validated using the ZIP-215 rules, which allows unreduced y-coordinates. Points are ensured valid by performing decompression, which finds a solution to the curve equation, or returns an error.

Adds references to ZIP-215 and #626 which is an issue about potentially adding support for the RFC8032/NIST validation criteria in the future.

Removes the previous warning that points are unvalidated: they're
validated using the ZIP-215 rules, which allows unreduced y-coordinates.
Points are ensured valid by performing decompression, which finds a
solution to the curve equation, or returns an error.

Adds references to ZIP-215 and #626
which is an issue about potentially adding support for the RFC8032/NIST
validation criteria in the future.
Copy link

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@rozbb rozbb merged commit d5ef57a into main Sep 19, 2024
28 checks passed
@NikolaWissenklaus
Copy link

Great!

@rozbb rozbb deleted the ed/verifying-key-from-bytes-rustdoc branch September 20, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants