Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave mattermost team when all channels left test sometimes fails #31

Open
dalcde opened this issue Aug 31, 2020 · 4 comments
Open

Leave mattermost team when all channels left test sometimes fails #31

dalcde opened this issue Aug 31, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@dalcde
Copy link
Owner

dalcde commented Aug 31, 2020 •
edited
Loading

See node 10.16 on https://github.com/dalcde/matrix-appservice-mattermost/runs/1049377207

This seems to only happen with node 10.16
@dalcde dalcde added the bug Something isn't working label Aug 31, 2020
@dalcde
Copy link
Owner Author

dalcde commented Aug 31, 2020 •
edited
Loading

In the aforementioned log, we see

2020-08-31 03:27:50,624 - synapse.access.http.8008 - 291 - INFO - POST-35 - 172.18.0.1 - 8008 - {@matrix_a:localhost} Processed request: 0.037sec/0.000sec (0.002sec, 0.001sec) (0.002sec/0.006sec/5) 2B 200 "POST /_matrix/client/r0/rooms/!dKcbdDATuwwphjRPQP%3Alocalhost/leave?access_token=<redacted> HTTP/1.1" "-" [0 dbevts]
2020-08-31 03:27:50,648 - synapse.http.client - 283 - INFO - as-sender-matrix-appservice-mattermost-9 - Sending request PUT http://appservice:9995/transactions/11?access_token=<redacted>
2020-08-31 03:27:50,650 - synapse.access.http.8008 - 291 - INFO - POST-36 - 172.18.0.1 - 8008 - {@matrix_a:localhost} Processed request: 0.060sec/0.003sec (0.003sec, 0.000sec) (0.001sec/0.009sec/5) 2B 200 "POST /_matrix/client/r0/rooms/!kmbTYjjsDRDHGgVqUP%3Alocalhost/leave?access_token=<redacted> HTTP/1.1" "-" [1 dbevts]
2020-08-31 03:27:50,657 - synapse.http.client - 316 - INFO - as-sender-matrix-appservice-mattermost-9 - Received response to PUT http://appservice:9995/transactions/11?access_token=<redacted>: 200
2020-08-31 03:27:50,676 - synapse.access.http.8008 - 291 - INFO - GET-38 - 172.18.0.1 - 8008 - {@matterbot:localhost} Processed request: 0.007sec/0.001sec (0.000sec, 0.000sec) (0.002sec/0.004sec/1) 498B 200 "GET /_matrix/client/r0/rooms/!kmbTYjjsDRDHGgVqUP%3Alocalhost/joined_members?access_token=<redacted> HTTP/1.1" "-" [0 dbevts]
2020-08-31 03:27:50,678 - synapse.access.http.8008 - 291 - INFO - GET-37 - 172.18.0.1 - 8008 - {@matterbot:localhost} Processed request: 0.009sec/0.002sec (0.001sec, 0.000sec) (0.003sec/0.004sec/1) 498B 200 "GET /_matrix/client/r0/rooms/!dKcbdDATuwwphjRPQP%3Alocalhost/joined_members?access_token=<redacted> HTTP/1.1" "-" [0 dbevts]
2020-08-31 03:28:19,204 - synapse.metrics - 541 - INFO -  - Collecting gc 1

after which the test times out.

Here matrix correctly received two leave requests, but only sends out one message to the appservice. A transaction is allowed to contain multiple events, but perhaps something isn't handling the event properly. Notice, however, that the appservice transaction is sent before the second message is processed.

The same behaviour is observed in https://github.com/dalcde/matrix-appservice-mattermost/runs/1049377207

@dalcde
Copy link
Owner Author

dalcde commented Sep 1, 2020

The bug is reproduced on Node 14.9.0

dalcde added a commit that referenced this issue Sep 1, 2020
@dalcde
Upgrade synapse to 1.19.0
72f1447 
If #31 is a synapse bug, this might resolve the problem
dalcde added a commit that referenced this issue Sep 3, 2020
@dalcde
Avoid triggering #31 in tests
4d6c5db 
This doesn't fix the underlying problem, but it is very helpful for
tests to not randomly fail for reasons that have nothing to do with the
commit.
@dalcde
Copy link
Owner Author

dalcde commented Sep 3, 2020

As per 4d6c5db, tests should no longer fail this way, but the problem itself is not solved

@dalcde
Copy link
Owner Author

dalcde commented Sep 14, 2020

See also https://github.com/dalcde/matrix-appservice-mattermost/runs/1112663362 and https://github.com/dalcde/matrix-appservice-mattermost/runs/1104752248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalcde