Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to org-roam v2 #92

Merged
merged 42 commits into from
Jul 17, 2021
Merged

migrate to org-roam v2 #92

merged 42 commits into from
Jul 17, 2021

Conversation

d12frosted
Copy link
Owner

@d12frosted d12frosted commented May 3, 2021 •
edited
Loading

This PR is to track progress of migration to org-roam v2.

Fixes #36
Fixes #57
Fixes #98

@d12frosted d12frosted force-pushed the feature/org-roam-v2 branch 3 times, most recently from 2d579a5 to 5a5b5b9 Compare May 6, 2021 06:00
@d12frosted
Copy link
Owner Author

d12frosted commented May 6, 2021 •
edited
Loading

27.1 fails for unknown reasons. Since I haven't yet played with the latest version of org-roam, I don't fully understand how selection works.

@d12frosted d12frosted force-pushed the feature/org-roam-v2 branch 7 times, most recently from 5d494b3 to 43f91c5 Compare May 9, 2021 10:39
@d12frosted
Copy link
Owner Author

Ok, it seems something shitty happens to note string representation in Emacs 27:

 [00:28.520]  searching for title Reference and tags (tag1 tag2): note Duplicating Term #(tag3) => nil
[00:28.520]  searching for title Reference and tags (tag1 tag2): note Duplicating Term #(tag2 tag1) => nil
[00:28.520]  searching for title Reference and tags (tag1 tag2): note without-title.org #nil => nil
[00:28.520]  searching for title Reference and tags (tag1 tag2): note Note without META #nil => nil
[00:28.520]  searching for title Reference and tags (tag1 tag2): note Reference #(tag2 tag1) => t
[00:28.520]  searching for title Reference and tags (tag1 tag2) => #tag2 #tag1 #tag2 #tag
[00:28.521]  user typed: #tag2 #tag1 #tag2 #tag => (#tag2 #tag1 #tag2 #tag . #s(vulpea-note ff01962f-47c2-4a32-9bf4-990e41090a9b Duplicating Term /tmp/note-filesgUaKaO/same-name-1.org (tag2 tag1) 0))
vulpea-select

Going to ignore for now.

@d12frosted d12frosted mentioned this pull request May 9, 2021
Merged
@d12frosted
(feat) migrate to org-roam v2
50c397a
@d12frosted
(dev) use local copy of org-roam
2b5d78b 
This is needed until org-roam v2 is released
@d12frosted
(feat) allow to pass extra properties in vulpea-create
389a545
@d12frosted
(dev) linter
953c815
@d12frosted
(feat) simplify vulpea-create API by flattening template
8b9667b
@d12frosted
(doc) actualise readme
ae58fcf
@d12frosted
(feat) vulpea-buffer-title-set function
8cb1648
@d12frosted
(feat) buffer-prop functions
606d85c
@d12frosted
(feat) support tags in vulpea-create
675fb50
@d12frosted
(dev) fix path to org-roam
690963a
@d12frosted
(dev) use a helper for better selection of notes in tests
89cee4d
@d12frosted
(dev) be a little verbose to understand what's wrong in Emacs 27
b81c66c
@d12frosted
(feat) filetags manipulation helpers
5b2cfd5
@d12frosted
(feat) support string quoting in vulpea-buffer-prop-get-list
6e5ae3f
@d12frosted
(feat) vulpea-buffer-prop-set-list
5196c5c
@d12frosted
(dev) remove redundant message
c22d736
@d12frosted
(dev) linter
2a3936e
@d12frosted
Copy link
Owner Author

I am going to use it for several days more and merge it.

@d12frosted d12frosted force-pushed the feature/org-roam-v2 branch 2 times, most recently from 2cd89b6 to a75df24 Compare May 18, 2021 07:59
@d12frosted
(feat) vulpea-insert
8ff428f
@d12frosted
(feat) treat empty values as nil in vulpea-buffer-prop-get
f65671a 
Most probably, vulpea-buffer-prop-set should also trim result.
@d12frosted
Copy link
Owner Author

d12frosted commented May 30, 2021 •
edited
Loading

The failure is unrelated to f65671a, but rather to one of my latest PRs to org-roam :(

@d12frosted d12frosted mentioned this pull request May 31, 2021
Closed
@d12frosted d12frosted mentioned this pull request Jun 17, 2021
Open
@d12frosted d12frosted merged commit 16f6179 into master Jul 17, 2021
@d12frosted d12frosted deleted the feature/org-roam-v2 branch July 17, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@d12frosted