How to add to the vulpea-project-p DONE ToDo states but not archived

[DominikMendel]

This is kind of a niche question. I am using d12frosted's agenda.el to dynamically add the filetag project to a file if it contains and TODO states. Then from here my org-agenda-files is equal to only things tagged with project.

This brings up only a small problem for me. If a file has no TODOs, but a handful of DONE items, those DONE items won't appear in my org-agenda view. That means I cannot archive them from my org-agenda and they will linger in that file. Is there a simple way to add to the TODO states the DONE items, but not ARCHIVE'd DONE items?
This matters for me, because I currently ARCHIVE my DONE items locally to the file. Like * Tasks ** ARCHIVE :ARCHIVE:.

Relevant code snippet:

(defun vulpea-project-p ()
  "Return non-nil if current buffer has any todo entry.

TODO entries marked as done are ignored, meaning the this
function returns nil if current buffer contains only completed
tasks."
  (seq-find                                 ; (3)
   (lambda (type)
     (eq type 'todo))
   (org-element-map                         ; (2)
       (org-element-parse-buffer 'headline) ; (1)
       'headline
     (lambda (h)
       (org-element-property :todo-type h)))))

[d12frosted]

Hey @DominikMendel

You kind of answered your own question. Few things to note.

1. (org-element-property :todo-type h) returns one of the 3 values: nil (when there is no TODO cookie), todo (when the task is not completed yet as per org-todo-keywords) and done (when the task is completed as per org-todo-keywords).
2. You can also access tags via :tags property and check for ARCHIVE to be missing.

You can fetch it all together roughly like this:

(defun vulpea-project-p ()
  "Return non-nil if current buffer has any todo entry."
  (org-element-map
      (org-element-parse-buffer 'headline)
      'headline
    (lambda (h)
      (and (org-element-property :todo-type h)
           (not (seq-contains-p (org-element-property :tags h)
                                "ARCHIVE"))))
    nil 'first-match))

[DominikMendel]

Hi again @d12frosted :)

Thanks for the response, this looked good. I gave it a try but it fell short a little bit. It didn't work for the archived items, it still saw them and still added the :project filetag. I found out exactly why, but sadly with my poor elisp coding I don't know the proper way to fix it.

org-element-propery :tags from the documentation states "Headline's tags, if any, without the archive tag. (list of strings)."
So it looks like the correct option to use would be :archivedp which says : Non-nil if the headline has an archive tag (boolean).

So I know that the lines of code here need to change.

(not (seq-contains-p (org-element-property :tags h)
                                "ARCHIVE"))

I have tried a few things, they seem close but I still get the same results.
First:
(not (org-element-property :archivedp h))
Second:
(not (org-in-archived-heading-p h))

I feel like I am learning a lot of elisp from seeing your examples. So again, thanks a lot.

[DominikMendel]

For what it's worth, since I thought this might be the issue, my org-use-tag-inheritance is t. I'm unsure if this affects anything, but my org-archive-subtree-add-inherited-tags = infile.