Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Increase default renewal AUs from 168 to 336. #703

Merged
merged 6 commits into from
Jun 1, 2019

Conversation

simpsonw
Copy link
Contributor

@simpsonw simpsonw commented May 31, 2019

Description

Increased the default renewal Allocation Units from 168 to 336.

Checklist before merging Pull Requests

  • New Modified test(s) included to reproduce the bug/verify the feature
  • Add an entry in the changelog
  • Documentation created/updated (include links)
  • If creating/modifying DB models which will contain secrets or sensitive information, PR to clank updating sanitation queries in roles/sanitary-sql-access/templates/sanitize-dump.sh.j2
  • Reviewed and approved by at least one other contributor.
  • New variables supported in Clank

@coveralls
Copy link

coveralls commented May 31, 2019

Coverage Status

Coverage increased (+0.5%) to 38.587% when pulling 2ee223d on simpsonw:update_renewal_aus_336 into 1a3211a on cyverse:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 39.282% when pulling 20d27ea on simpsonw:update_renewal_aus_336 into 1a3211a on cyverse:master.

@simpsonw
Copy link
Contributor Author

I didn't add a new test for this but I updated an an existing one which failed after I increased the default AU allocations. I also added a script that makes running the tests within a Docker container easier.

Copy link
Contributor

@julianpistorius julianpistorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simpsonw!

@julianpistorius julianpistorius merged commit f58f2cb into cyverse:master Jun 1, 2019
@simpsonw simpsonw deleted the update_renewal_aus_336 branch July 29, 2019 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants