This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix exception handling preventing instance destroy #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianpistorius
approved these changes
Oct 4, 2018
When an instance was missing a floating ip, Nova would report "floating IP not found", we attempted to handle that case, by checking if the string matched "floating ip not found". They don't match so the exception would surface. Rather than performing frail checks, just try and give up.
cdosborn
force-pushed
the
permit-instance-destroy-when-floating-ip-is-missing
branch
from
b054910
to
f1a062d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an instance was missing a floating ip, Nova would report "floating IP not found", we attempted to handle that case, by checking if the string matched "floating ip not found". They don't match so the exception would surface.
Rather than performing frail checks, just try and give up.
Checklist before merging Pull Requests