This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix tacc timeout feature #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdosborn
force-pushed
the
fix-tacc-timeout-feature
branch
4 times, most recently
from
cafa211
to
f4048cf
Compare
cdosborn
force-pushed
the
fix-tacc-timeout-feature
branch
2 times, most recently
from
2fcfc66
to
3faa553
Compare
Several changes here that are all related. The original desired behavior for the timeout feature was to ensure that api/v1/profile didn't take an indefinite amount of time in user validation. We originally accomplished that by putting a timeout of 5 seconds into all calls to read from the tas api. This was wrong because there are some calls which rightfully should take more time (like getting all projects). Th purpose of this change is to add support for timeouts so that the one place that needed it could use it w/o affecting all the other places. This refactor allows you construct a driver with a specific timeout. That way the one place (user validation) could construct a driver with a short timeout, and handle a timeout exception appropriately. This change introduces private methods _tacc_api_get and _tacc_api_post to the driver so that it can provide a timeout in one place, and pass things like tacc_password once. The tacc_api_get and tacc_api_post methods have been changed to support timeout. They will eventually be incorporated into the driver.
cdosborn
force-pushed
the
fix-tacc-timeout-feature
branch
from
3faa553
to
8efb04f
Compare
julianpistorius
approved these changes
Oct 12, 2018
|
This is working for me locally and the tests passed after I fixed the merge conflict in the changelog. Merging PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Several tas api endpoints regularly take more than 5 seconds (ex. getting all projects) and were timing out
Solution
Refactor timeout feature so that the one place that needs a timeout can specify it and handle a timeout exception without affect all other uses of the tas api.
See the commit messages for a longer explanation of the refactor
Checklist before merging Pull Requests