Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Fix reference to deleted model #673

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Fix reference to deleted model #673

merged 2 commits into from
Sep 18, 2018

Conversation

cdosborn
Copy link
Contributor

@cdosborn cdosborn commented Sep 18, 2018 •
edited
Loading

Description

Problem

There was a lingering reference to a deleted model through

Solution

Remove the reference

The provider's config includes the dnsnameservers. Its use here is a relic.

Checklist before merging Pull Requests

  • Add an entry in the changelog
  • Reviewed and approved by at least one other contributor.

@cdosborn
Fix reference to deleted model
f20912d 
When ProviderDNSServerIP was removed, provider.dns_server_ips still referenced
the relationship. This model is safe to delete, we just need to ensure the dns
name servers are included instead in a provider's config
@cdosborn
Update changelog
2fe5b16
@coveralls
Copy link

coveralls commented Sep 18, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 37.865% when pulling 2fe5b16 on cdosborn:fix-reference-to-deleted-model into 0068fcf on cyverse:master.

@cdosborn cdosborn changed the base branch from master to v34 September 18, 2018 16:40
@cdosborn cdosborn merged commit dfe809b into cyverse:v34 Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c-mart c-mart c-mart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdosborn @coveralls @c-mart