This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Simplify v2 action api, fix volume detach 500 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianpistorius
approved these changes
Aug 31, 2018
When detaching a volume, run_instance_action would return the volume. The api would then attempt to return that volume object, rather than a serialized volume. The action api doesn't need to return anything besides the status of the action. It should definitely not know how serialize objects like instances and volumes.
cdosborn
force-pushed
the
fix-api-v2-volume-detach
branch
2 times, most recently
from
92f2906
to
c7ff5c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When detaching a volume, run_instance_action would return the volume. The api would then attempt to return that volume object, rather than a serialized volume. The action api doesn't need to return anything besides the status of the action. It should definitely not know how serialize objects like instances and volumes.
Checklist before merging Pull Requests