This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix volume quota update #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Updating a user's volume quota, would return a successful response including the updated quota values. However, the values wouldn't actually be updated in openstack. Solution: Pass a tenant id rather than a tenant name in /os-quota-sets/<tenant id>
|
Targeting this against v32, because this needs to go in for j7m |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Updating a user's volume quota, would return a successful response including the updated quota values. However, the values wouldn't actually be updated in openstack.
Solution
Pass a tenant id rather than a tenant name in /os-quota-sets/
The current OS api[1] silently fails, reporting a successful update, even when the update did not occur. Tested against all providers in use. Verified that storage is updated from OS pov.
[1] https://developer.openstack.org/api-ref/block-storage/v3/index.html#quota-sets-extension-os-quota-sets
Checklist before merging Pull Requests