This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix quota update bug "index out of range" #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Updating a users quota, would trigger an index out of range error Solution: Use a different api for fetching the users tenant id In the act of changing quota, we require a tenant id for the user. The original api which fetched this id, did so through a side effect of establishing a connection to the nova compute api. This side effect changed when marana was upgraded to use the 2.1 compute api. We are no longer using this method in rtwo `_get_tenant_id`.
cdosborn
force-pushed
the
fix-broken-quota-update
branch
from
3a02602
to
377f425
Compare
julianpistorius
approved these changes
Apr 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix quota update causing index out of range
Problem
Updating a users quota, would trigger an index out of range error
Solution
Use a different api for fetching the users tenant id
In the act of changing quota, we require a tenant id for the user. The original api which fetched this id, did so through a side effect of establishing a connection to the nova compute api. This side effect changed when marana was upgraded to use the 2.1 compute api rather than the 2 version. It changed as a result of a new url returned from the service catalog discovery.
We are no longer using this method in rtwo
_get_tenant_id.I tested against marana, workshop, iu, and tacc.
Checklist before merging Pull Requests