This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Make another attempt to fix adding fixed ips #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer removing ports. After upgrading Marana to Pike we found that ports which were attached post boot, would never successfully attach. A workaround was discovered to enable allow-hotplug for the given interface in cloud-init, but it was deemed more complicated than simply preserving the ports. We were deleting/recreating the ports in the first place, because of a bug which affected j7m https://bugs.launchpad.net/nova/+bug/1759924. This reverts commit af002eb.
…zone issue
Problem:
After upgrading Marana to Pike we found that ports which were attached
post boot, would never successfully attach. A workaround was discovered to
enable allow-hotplug for the given interface in cloud-init, but it was
deemed more complicated than simply preserving the ports.
We were deleting/recreating the ports in the first place, because of a bug
which affected j7m https://bugs.launchpad.net/nova/+bug/1759924.
Solution
Rather than add/delete ports, add/remove fixed ips, but explicitly check
if we're dealing with the availability zone issue and then try
deleting/recreating the port. For some reason j7m is able to attach ports
post boot. If its discovered that this is because of some race condition,
we will need another workaround.
c-mart
reviewed
Apr 13, 2018
There was a problem hiding this comment.
If this lets us recover currently stopped/shelved instances with no fixed IP without having to reboot them again, +1.
Going forward with modern, load-balanced control plane, I suspect that we're causing unnecessary trouble for ourselves by deleting fixed IPs, ports, and private networks to begin with. I suspect that if we stopped doing that then there would be no need for these sorts of hackarounds.
service/tasks/driver.py
Outdated
| instance.id, network_id=network_id) | ||
|
|
||
| elif not instance._node.private_ips: | ||
| # Only add fixed ip, if the instance doesn't already have on |
There was a problem hiding this comment.
typo, "doesn't already have one"
cdosborn
force-pushed
the
fix-broken-fixed-ip-add
branch
from
fdf4704
to
1277702
Compare
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try different approach to working around openstack port availability zone issue
Problem
After upgrading Marana to Pike we found that ports which were attached post boot, would never successfully attach. This meant that every time an instance would boot (start/unshelve) minus initial launch, it would not be reachable. A workaround was discovered to enable allow-hotplug for the given interface in cloud-init, but it was deemed more complicated than simply preserving the ports.
We were deleting/recreating the ports in the first place, because of a bug which affected j7m https://bugs.launchpad.net/nova/+bug/1759924.
Solution
Rather than add/delete ports, add/remove fixed ips, but explicitly check if we're dealing with the availability zone issue and then try deleting/recreating the port. It is unknown why j7m is able to attach ports post boot, and we cannot.
I tested the following scenarios. Start/stop, shelve/unshelve on marana and indiana. (and in particular the shelve scenario where the AZ was incorrect)
Checklist before merging Pull Requests