This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
(WIP) Problem: Django tests fail when run consecutively #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular failures happen in the VCR checks for whether the cassettes have all been played. This is because the TAS API results are cached on disk. Solution: Disable caching when testing by using the `DummyCache` backend
| 'default': { | ||
| 'BACKEND': 'django.core.cache.backends.dummy.DummyCache', | ||
| } | ||
| } |
There was a problem hiding this comment.
This could lead to unintended consequences.. TESTING previously enabled the ability to run ./manage.py test.
Rather than overloading TESTING perhaps we could go this route instead?
There was a problem hiding this comment.
Wouldn't be the first time I'm confused about the historical purpose for a variable/setting. The problem is we probably need caching disabled for all tests - so it becomes very tedious very quickly. But maybe your idea of making the caching backend configurable is the answer.
|
Ok, I'll rework this PR to make the backend configurable instead. |
julianpistorius
changed the title
2 tasks
|
Closed in favor of #626 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular failures happen in the VCR checks for whether the
cassettes have all been played. This is because the TAS API results are
cached on disk.
Solution: Disable caching when testing by using the
DummyCachebackendChecklist before merging Pull Requests
[ ] New test(s) included to reproduce the bug/verify the feature[ ] Documentation created/updated at Example link to documentation to give context to the feature[ ] If necessary, include a snippet in CHANGELOG.md[ ] New variables supported in Clank[ ] New variables committed to secrets repos