Merge pull request #142 from dominicfraser/chain_command_focused_fals…

…e_positive unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused'
cypress-io · Sep 18, 2023 · d5b89f4 · d5b89f4
2 parents b9f7a26 + 0c525e1
commit d5b89f4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rules/unsafe-to-chain-command.js b/lib/rules/unsafe-to-chain-command.js
@@ -19,7 +19,7 @@ const unsafeToChainActions = [
   'check',
   'dblclick',
   'each',
-  'focus',
+  'focus$',
   'rightclick',
   'screenshot',
   'scrollIntoView',

diff --git a/tests/lib/rules/unsafe-to-chain-command.js b/tests/lib/rules/unsafe-to-chain-command.js
@@ -14,6 +14,10 @@ ruleTester.run('action-ends-chain', rule, {
       code: 'cy.get("new-todo").type("todo A{enter}"); cy.get("new-todo").type("todo B{enter}"); cy.get("new-todo").should("have.class", "active");',
       parserOptions,
     },
+    {
+      code: 'cy.focused().should("be.visible");',
+      parserOptions,
+    },
   ],
 
   invalid: [
@@ -27,6 +31,11 @@ ruleTester.run('action-ends-chain', rule, {
       parserOptions,
       errors,
     },
+    {
+      code: 'cy.get("new-todo").focus().should("have.class", "active");',
+      parserOptions,
+      errors,
+    },
     {
       code: 'cy.get("new-todo").customType("todo A{enter}").customClick();',
       parserOptions,