fix: fixed issue with CT + electron + run mode not exiting properly #25585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 flaky tests on run #43454 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse | ||
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| cy.origin waiting > alias > waits for the route alias to have a response | ||
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| ... > runs generated spec |
Screenshot
|
|
The first 5 flaky specs are shown, see all 23 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
ZachJW34
approved these changes
Jan 25, 2023
| @@ -814,10 +814,6 @@ async function runSpecs (options: { config: Cfg, browser: Browser, sys: any, hea | |||
| })), | |||
| }) | |||
|
|
|||
| if (testingType === 'component') { | |||
There was a problem hiding this comment.
E2E and CT should be closing the browser equivalently so this removal looks good to me!
AtofStryker
approved these changes
Jan 25, 2023
lmiller1990
approved these changes
Jan 25, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 26, 2023
* develop: (27 commits) refactor: remove unused cloud routes (#25584) chore: fix issue template formatting issue (#25587) fix: fixed issue with CT + electron + run mode not exiting properly (#25585) chore(deps): update dependency ua-parser-js to v0.7.33 [security] (#25561) fix: add alternative binary names for edge-beta (#25456) chore: add batch execution to CloudDataSource (#22457) chore: End a/b campaigns for aci smart banners (#25504) chore: release @cypress/schematic-v2.5.0 fix(cypress-schematic): do not disable e2e support file (#25400) chore: adding memory issue template (#25559) feat: Add Angular CT Schematic (#24374) chore: enforce changelog entries on PR reviews (#25459) chore: bump package.json to 12.4.0 [run ci] (#25556) feat: Add 'type' option to `.as` to store aliases by value (#25251) chore: release @cypress/webpack-dev-server-v3.2.3 feat: Display line break in cy.log (#25467) chore: update types (#25538) fix: Revert "fix: adding emergency garbage collection for chromium-based browsers" (#25546) fix: percy - wait to take snapshot until previous tooltips are gone (#25522) feat: support data-qa selector in selector playground (#25475) ...
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removed unneeded code that was causing component tests to hang in
electronwhen running multiple specs inrunmode.Prior to d1dc125, after running the first spec in electron, the browser instance is cleared and never set again even after a new spec is started. When
openProject.closeBrowser()was called, the instance was null and the promise resolved.After d1dc125, after running the first spec in electron, the browser instance is cleared but then it is set to the new browser instance when the new spec is started. The instance is not cleared again after that. Thus, when
openProject.closeBrowser()was called, the instance was not null and the promise never resolved causing the hang.Steps to test
runmode inelectronand verify the process is correctly exited.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?