-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update @cypress/schematic to use proper e2e config for 10.0.0 #19827
feat: update @cypress/schematic to use proper e2e config for 10.0.0 #19827
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
'baseUrl': '<%= baseUrl%>', | ||
'e2e': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for explicitly specifying config options that are the default values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and removed them. However, this does bring up a good point about IA. I can find this on configuring CT(https://deploy-preview-4186--cypress-docs.netlify.app/guides/getting-started/component-framework-configuration), but I can't find an equivalent on E2E testing. The config reference with that info is kind of buried - https://deploy-preview-4186--cypress-docs.netlify.app/guides/references/configuration.
IMO referencing pieces of that doc more in the framework config pieces would help users - especially new users or those with limited experience configuring Cypress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. A few improvements to the tests and some questions around .cy
vs .spec
that need some clarification IMO
npm/cypress-schematic/src/schematics/ng-add/files/cypress/tsconfig.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I don't see anything unusual here. I'm no angular expert, but code seems 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job @admah!
658b998
to
9a600fb
Compare
npm/cypress-schematic/src/schematics/ng-add/files/cypress/fixtures/example.json
Outdated
Show resolved
Hide resolved
1bed07a
Update npm/cypress-schematic/src/schematics/ng-add/files/cypress/fixtures/example.json Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
1bed07a
to
da0e42b
Compare
* 10.0-release: (25 commits) fix(unify): improve dev server config ergonomics (#19957) feat: add spec pattern modal (#19801) fix: Windows e2e project scaffolding issues (#19938) feat: update @cypress/schematic to use proper e2e config for 10.0.0 (#19827) fix: correctly migrate projects with custom integration folder (#19929) fix: component spec creation with spec pattern (#19862) fix: missed committing yarn.lock after merge conflict fix: correct reference branch / commitSha in performance-reporter (#19941) feat: update navbar UI per Figma (#19926) fix: seed examples files when no e2e directory is created (#19768) chore: remove windy lightBlue warning test: component test updates (#19925) feat: Focus browser from select browser screen and on dashboard login (#19842) test: Honeycomb system-test reporter (#19855) fix(deps): update dependency engine.io to v5.2.1 [security] feat: Retain fileName when working with aliased fixtures and files (#19820) Update release-process.md Update release-process.md Update release-process.md Update release-process.md ...
This PR updates the cypress-schematic package to:
ng-add
schematic.cy.ts
files when generating new e2e specsCT configuration will have to go in at a later date since Angular CT is still not fully fleshed out.