Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger and set: fix default flow assignment for n=0 tasks. #6367

Open
wants to merge 4 commits into
base: 8.3.x
Choose a base branch
from

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Sep 11, 2024

Close #6361

FIX

  • by default (i.e., --flow option not used), existing (n=0) tasks should keep their existing flow numbers

Tidy

  • remove redundant option checking, now done during command validation
  • clarify command and schema help

NEW

  • explicit use of --flow will merge the given flow numbers into existing (n=0) tasks
    (this seems sensible to me, and I can't think of a reason not to do it)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added this to the 8.3.4 milestone Sep 11, 2024
@hjoliver hjoliver self-assigned this Sep 11, 2024
@hjoliver hjoliver force-pushed the fix-trigger-flow-bug branch 6 times, most recently from d7178d3 to 29ddf4f Compare September 11, 2024 08:11
@oliver-sanders oliver-sanders modified the milestones: 8.3.4, 8.3.5 Sep 11, 2024
@hjoliver hjoliver changed the base branch from master to 8.3.x September 17, 2024 22:05
@hjoliver hjoliver marked this pull request as ready for review September 18, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errant flow merge when triggering
2 participants