Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vr: restart the workflow with no changes according to user prompt #6354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vr: restart the workflow with no changes according to user prompt #6354

wants to merge 1 commit into from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Sep 3, 2024 •
edited
Loading

  • Closes cylc vr - restart with no changes? #6261
  • If there are no changes to reinstall AND the workflow is stopped, rather than just exiting, the cylc vr command will now prompt the user to give them the option of restarting the workflow.
  • This makes them aware there are no changes to reinstall (which may be an error on their part) but still gives them the option of restart without having to edit or rerun the command.

An odd feature to introduce at a bugfix release, however, it's kinda a UX type issue so it might make sense.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added small could be better Not exactly a bug, but not ideal. labels Sep 3, 2024
@oliver-sanders oliver-sanders added this to the 8.3.4 milestone Sep 3, 2024
@oliver-sanders oliver-sanders self-assigned this Sep 3, 2024
@oliver-sanders
vr: restart the workflow with no changes according to user prompt
8021ce9 
* Closes cylc#6261
* If there are no changes to reinstall AND the workflow is stopped,
  prompt the user to see whether they want to restart it anyway.
* This makes `cylc vr` more useful as the "I want to restart my
  workflow" command.
* But it also ensures that they are aware if no changes are present
  as they might have forgotten to press save or run the command on
  the wrong workflow or whatever.
@oliver-sanders oliver-sanders marked this pull request as ready for review September 4, 2024 09:29
@oliver-sanders oliver-sanders modified the milestones: 8.3.4, 8.3.5 Sep 11, 2024
@hjoliver
Copy link
Member

(Looks good, but I haven't done a proper review yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver Awaiting requested review from hjoliver

At least 1 approving review is required to merge this pull request.

Assignees

@oliver-sanders oliver-sanders

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
8.3.5
Development

Successfully merging this pull request may close these issues.

cylc vr - restart with no changes?
2 participants
@oliver-sanders @hjoliver