expiry: prevent expired tasks from retrying automatically #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Sep 3, 2024
| @@ -2150,3 +2150,51 @@ async def test_trigger_unqueued(flow, scheduler, start): | |||
| assert not schd.pool.task_queue_mgr.force_released, ( | |||
| "Triggering an unqueued task should not affect the force_released list" | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('expire_type', ['clock-expire', 'manual']) | |||
There was a problem hiding this comment.
Manual expiry wasn't broken, but I included it in this test for completeness.
oliver-sanders
force-pushed
the
6284
branch
3 times, most recently
from
547da8f
to
ece46bc
Compare
hjoliver
approved these changes
Sep 3, 2024
| @@ -2239,6 +2239,7 @@ def clock_expire_tasks(self): | |||
| # check if this task is clock expired | |||
| and itask.clock_expire() | |||
| ): | |||
| self.task_queue_mgr.remove_task(itask) | |||
|
Technically this should have a change log entry (although I doubt many have run into the bug.) |
wxtim
approved these changes
Sep 4, 2024
|
on:testspass - will push button |
|
Tests passed, pressing the button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6284
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.