fix no rose vars in cylc view #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
added
bug
small
question
wxtim
force-pushed
the
fix_no_rose_vars_in_cylc_view
branch
from
f512b70
to
9226eab
Compare
5 tasks
Can do that in the cylc-rose repo where there should be some e2e tests for this? |
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
See the link against the "tests" checklist item. |
oliver-sanders
removed
the
question
oliver-sanders
requested review from
oliver-sanders
and removed request for
datamel
oliver-sanders
approved these changes
Feb 16, 2023
oliver-sanders
requested changes
Feb 16, 2023
oliver-sanders
approved these changes
Feb 16, 2023
|
All failures caused by hitting codecov rate limits. |
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Feb 17, 2023
…lc into fix_localhost_platform_matching * 'fix_localhost_platform_matching' of github.com:wxtim/cylc: Fix a bug preventing `cylc vip --workflow-name=foo` from working. (cylc#5349) fix no rose vars in cylc view (cylc#5367) Cylc lint fixes (cylc#5363) data store: support unsatisfied ext_trigger fix mypy fail caused by python/mypy#13969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes an issue documented in the PR.
Issue Description
Cylc view does not have access to the Cylc Rose command line options (
-O,-S,-D), when it ought to have.PR Information
I have added the Cylc Rose CLI options to
cylc view. It works manually, but ought to be tested in Cylc Rose.Question - do we want to test the Cylc Rose option adder in this repo by looking at the
--helpoutput?Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry not included - this is not a change that can affect users?.?.xbranch.