Skip to content

Commit

Permalink
Apply suggestions from code review [skip ci]
Browse files Browse the repository at this point in the history
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
  • Loading branch information
hjoliver and wxtim committed Mar 12, 2024
1 parent 5642c84 commit bef6776
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 1 addition & 4 deletions tests/integration/scripts/test_completion_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@
See also the more extensive unit tests for this module.
"""

from cylc.flow.scripts.completion_server import (
_list_prereqs_and_outputs,
complete_cylc,
)
from cylc.flow.scripts.completion_server import complete_cylc


def setify(coro):
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async def test_trigger_invalid(mod_one, start, log_filter, flow_strs):
"""Ensure invalid flow values are rejected."""
async with start(mod_one) as log:
log.clear()
assert mod_one.pool.force_trigger_tasks(['*'], flow_strs) == None
assert mod_one.pool.force_trigger_tasks(['*'], flow_strs) is None
assert len(log_filter(log, level=logging.WARN)) == 1


Expand Down
4 changes: 3 additions & 1 deletion tests/unit/scripts/test_completion_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -728,4 +728,6 @@ async def test_prereqs_and_outputs():
assert await _list_prereqs_and_outputs([]) == ([], [])

# if an invalid workflow is provided, we can't list anything
assert await _list_prereqs_and_outputs([Tokens(workflow='no-such-workflow')]) == ([], [])
assert await _list_prereqs_and_outputs(
[Tokens(workflow='no-such-workflow')]
) == ([], [])

0 comments on commit bef6776

Please sign in to comment.