Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] use predefined Grafana dashboards uid, fixes #474 #480

Merged
merged 3 commits into from
May 17, 2022

Conversation

pashagolub
Copy link
Collaborator

[+] add uid to v8 dashboards
[-] fix import_all.sh and set_up_grafana_dashboards*.sh
[-] fix delete_all_old_pw2_dashes.sh

[+] add `uid` to v8 dashboards
[-] fix `import_all.sh` and `set_up_grafana_dashboards*.sh`
[-] fix `delete_all_old_pw2_dashes.sh`
@yanchenko-igor
Copy link
Contributor

looks good, but maybe we should fix influxdb and prometheus dashboards as well?

@pashagolub
Copy link
Collaborator Author

Influxdb fixed by set_up_grafana_dashboards.sh. I just didn't update JSONs since it doesn't matter here.
Prometheus needs a separate issue and branch, I believe. The provisioning of its dashboards made somehow different

@yanchenko-igor
Copy link
Contributor

Influxdb fixed by set_up_grafana_dashboards.sh. I just didn't update JSONs since it doesn't matter here. Prometheus needs a separate issue and branch, I believe. The provisioning of its dashboards made somehow different

Well, if we deploy pgwatch2 using helm chart, we don't run the script, we are using the json files.

@pashagolub
Copy link
Collaborator Author

Oh, I didn't know that! Good point!
@yanchenko-igor, would you please point me to how we do provisioning with helm charts?

@yanchenko-igor
Copy link
Contributor

Oh, I didn't know that! Good point! @yanchenko-igor, would you please point me to how we do provisioning with helm charts?

It's just adding the json files to Configmap https://github.com/cybertec-postgresql/pgwatch2/blob/helmchart/helm-chart/templates/grafana-dashboards.yaml

@pashagolub
Copy link
Collaborator Author

Thanks! Will add uid for influx jsons as well

@yanchenko-igor
Copy link
Contributor

What about linkUrl in other json files?

@pashagolub
Copy link
Collaborator Author

Crap! :-(

@pashagolub pashagolub merged commit aef7141 into master May 17, 2022
@pashagolub pashagolub deleted the 474_fix_dashboard_permlinks branch May 17, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants