Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to use mingw python #4909

Merged

Conversation

Kreijstal
Copy link
Contributor

@Kreijstal Kreijstal commented Jul 18, 2022

Basically adds a flag to windows make files so that it can compile with
mingw python as well as downloading python version externally
This is for convenience and also reduce the non interactive dependencies if you want to package it later

Description
So it's really hard to use the mingw's version of python with webots, in this pull request I edit the makefiles in such a way that it retains the current behaviour but given a flag it uses mingw's version of python instead of using python home.

Could fix #4595

Basically adds a flag to windows make files so that it can compile with
mingw python as well as downloading python version externally
This is for convenience and also reduce the non interative dependencies
in th
@Kreijstal Kreijstal requested a review from a team as a code owner July 18, 2022 22:41
@omichel omichel added the enhancement Implementation of a minor feature label Jul 19, 2022
@omichel omichel added this to the R2023a milestone Jul 19, 2022
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice contribution.
I will also document it on the wiki page.

Note: you will be able to merge this PR once you accept my GitHub invite to become a member of The Cyberbotics Committers group.

@Kreijstal Kreijstal merged commit 598cec3 into cyberbotics:develop Jul 19, 2022
@omichel
Copy link
Member

omichel commented Jul 19, 2022

Thank you!
See my wiki addition here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Implementation of a minor feature
Development

Successfully merging this pull request may close these issues.

2 participants