Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP on FLS and Field Masking optimization #28

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

cwperks
Copy link
Owner

@cwperks cwperks commented Aug 30, 2024

Description

This PR revisits the data structure that carries the <concrete index> -> Set<String> maskedFields (or FLS) that is carried on the ThreadContext. Currently, the datastructure is carrying the entire evaluatedDlsFlsConfig which iterates through all roles and computes a map of concrete indices matching the mattern on any role -> the set of masked Fields or Fls.

An example data structure is like this:

{first-test-index=[lyrics::/(?<=.{1})./::*, artist::/(?<=.{1})./::*], second-test-index=[lyrics::/(?<=.{1})./::*]}

The problem with this is that if a request is only on a single index, this data structure will still contain all matched concrete indices -> set of maskedFields on the ThreadContext for every request.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
… not fully resolve to concrete index for datastream

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…fore

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant