Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude_roles configuration parameter to LDAP authorization backend #20

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Owner

@cwperks cwperks commented Feb 5, 2024

Description

Adds a new config value for LDAP Authorization Backend called exclude_roles. This config value lets a cluster administrator configure a list of patterns of roles to exclude from an external LDAP system to limit the backend roles fetched for a user to the most pertinent roles for OpenSearch.

MaciejMierzwa and others added 7 commits December 8, 2023 10:44
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Hide ldap roles Add exclude_roles configuration parameter to LDAP authorization backend Feb 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (321604c) 65.62% compared to head (8141cd5) 65.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   65.62%   65.85%   +0.22%     
==========================================
  Files         298      298              
  Lines       21247    21258      +11     
  Branches     3457     3464       +7     
==========================================
+ Hits        13943    13999      +56     
+ Misses       5583     5525      -58     
- Partials     1721     1734      +13     
Files Coverage Δ
...ava/com/amazon/dlic/auth/ldap/util/LdapHelper.java 67.50% <ø> (ø)
...g/opensearch/security/support/WildcardMatcher.java 66.87% <83.33%> (+2.13%) ⬆️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 62.71% <55.55%> (+0.21%) ⬆️
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java 47.98% <50.00%> (+16.75%) ⬆️

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants