Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization fix scratch #15

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Initialization fix scratch #15

wants to merge 53 commits into from

Conversation

cwperks
Copy link
Owner

@cwperks cwperks commented Dec 20, 2023

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Only allow TransportConfigUpdateAction after node has been set as boo…
7ba39c9 
…tstrapped

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Set in finally block and change name to bgThreadComplete
d05da1a 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add tests that ensure the bg thread completes during bootstrap
58d6f45 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add test to provide initialize with securityadmin works
c2423b7 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Set background init to false to ensure that transport config update a…
d86feed 
…ctions can pass

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Update SecurityConfigurationTests
9606f38 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use CompletableFuture
0b764f1 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Wrap in doPrivileged
83961f0 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
doPrivileged
b211302 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Wrap with doPrivileged
0613161 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Assert not initialized
258fb28 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Rename beforeClass method
91cf472 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add AccessControllerWrappedThread
06b7513 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use threadContext to carry context
a3398e0 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Merge branch 'main' into initialization-fix
07902e2 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Merge branch 'main' into initialization-fix
d80e98d
@cwperks
Merge branch 'initialization-fix' of https://github.com/cwperks/security
67272e0 
 into initialization-fix
@cwperks
Small update
7b73715 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use Awaitility
4b99681 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use Awaitility
65875b5 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Temporarily adding ignore
5b4ff85 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use resetSystemProperties
424a148 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use stop and start instead of restart
83bb6a1 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Remove reset of default dir
d9912ed 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Try increasing wait time to 30s
55a99ac 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Remove restart
b44574e 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Debug testInvalidDefaultConfig
ef3dc82 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use path.home instead of system props
066622c 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add build.gradle
bd77232 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add settings2
2cf0f96 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Limit to one test suite
d9f4b5c 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add debugging statements
7b2e429 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add more debug statements
4acf67e 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add more debug statements
d366eee 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
More debugging
50b2001 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add more debug statements
e805dc3 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add more debug
7631bfa 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add close hook to interrupt bgThread
88b4bcc 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add debug
231771a 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
debug
6f7782b 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
debug
fb977fd 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use bgThreadRunner.cancel
2b23d8f 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Instantiate in constructor
01de71c 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Cancel and interrupt
0766d1d 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Remove unecessary instantiation
73ed5f0 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Remove thread and use Runnable
a6e9999 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Completed future
114a01f 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Debug
7e0e0ba 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Increase pool size in test
23b4923 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Print parallelism
2b1b2fa 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Pass with -D
f10ac4e 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
GRADLE_OPTS
c52f0c1 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Increase parallelism
2d4de16 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford stephen-crawford is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@willyborankin willyborankin Awaiting requested review from willyborankin willyborankin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwperks