Allow SVG transfer function attributes #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good, thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following SVG transfer function (
<feFunc*>) attributes to the SVG allow list:amplitudeexponentinterceptslopetablevaluesAfaik, these are all of the attributes that are available on SVG component transfer functions (
offsetis already on the allow list).These attributes are used to control how colours are processed inside an
<feComponentTransfer>element. All of these attributes only accept numeric values, so I don't believe they can be used to trigger scripts or other malicious behaviours. Please let me know if I'm wrong there.Thanks again!
Background & Context
This should fix #984.
References