Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Popover API attributes #957

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

Gigabyte5671
Copy link
Contributor

Summary

This PR adds the new attributes from the Popover API to the list of allowed HTML attributes. This includes:

  • popover
  • popovertarget
  • popovertargetaction

These attributes are used to identify popover elements and control their behaviour. I don't believe they can be used to trigger scripts in any way, but please let me know if I'm wrong.

Thanks!

Background & Context

This API is quite new, but support for it is already estimated at ~84% (caniuse).

@cure53
Copy link
Owner

cure53 commented May 18, 2024

Thanks, we should be fine with those as far as I can see, time will tell.

@cure53 cure53 merged commit a34860b into cure53:main May 18, 2024
8 checks passed
@Gigabyte5671 Gigabyte5671 deleted the popover-api branch May 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants