Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/fix up jUnit tests #1749

Merged
merged 2 commits into from
Jan 8, 2024
Merged

refactor/fix up jUnit tests #1749

merged 2 commits into from
Jan 8, 2024

Conversation

luke-hill
Copy link
Contributor

Fix up a small amount of styling
Remove open ended steps to avoid IDE issues.

Description

Small tidies to jUnit legacy tests to keep them from being able to be debugged locally

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill luke-hill merged commit 09f4d30 into main Jan 8, 2024
15 checks passed
@luke-hill luke-hill deleted the refactor/amend_junit_tests branch January 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant