Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG update for cucumber/cucumber #251 #166

Merged
merged 2 commits into from
Aug 24, 2017
Merged

CHANGELOG update for cucumber/cucumber #251 #166

merged 2 commits into from
Aug 24, 2017

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Aug 24, 2017

Summary

CHANGELOG.md updates as per cucumber/cucumber #251

Details

Nothing huge in this change. Changed the file's name, added the contributing link to the top, and added my change to the list.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update

@mxygem mxygem merged commit eff397b into master Aug 24, 2017
@mxygem mxygem deleted the changelog-updates branch August 24, 2017 03:31
@paoloambrosio
Copy link
Member

What was wrong with just raising the PR? Discussion on Slack's #committers channel.

@mxygem mxygem restored the changelog-updates branch August 24, 2017 06:03
@mxygem mxygem mentioned this pull request Aug 24, 2017
Closed
@muggenhor muggenhor deleted the changelog-updates branch August 24, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxygem @paoloambrosio