Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to create webdav references for OCM shares #974

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested a review from labkode as a code owner July 15, 2020 10:20
@update-docs
Copy link

update-docs bot commented Jul 15, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@@ -1028,6 +1030,12 @@ func (s *svc) handleCS3Ref(ctx context.Context, opaque string) (*provider.Resour
return res.Info, nil
}

func (s *svc) handleWebdavRef(ctx context.Context, ri *provider.ResourceInfo) (*provider.ResourceInfo, error) {
// A webdav ref has the following layout: <storage_id>/<opaque_id>@webdav_endpoint
// TODO: Once file transfer functionalities have been added.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to access the remote data by issues a GET/PROPFIND response to obtain the necessary information dynamically.

We can merge this PR and add that later. @ishank011

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I added the TODO there. Once we have that functionality, I'll update this.

@labkode
Copy link
Member

labkode commented Jul 16, 2020

@ishank011
Copy link
Contributor Author

@labkode Aren't the tags only those specified within square brackets? I'll anyway try and see if this works

@labkode
Copy link
Member

labkode commented Jul 16, 2020

@ishank011 not sure either, test empirically :)

@labkode
Copy link
Member

labkode commented Jul 20, 2020

@ishank011 the creation of the webdav reference has to be optional, for example for Cubbit, they only need to implement the share creation but not propagating it to a storage reference. Can be add a configuration flag that this needs to be explicit?

@ishank011
Copy link
Contributor Author

ishank011 commented Jul 20, 2020

@labkode yes it's already there. It's created only if commit_share_to_storage_ref is set to true here.

@labkode labkode merged commit fd224e4 into cs3org:master Jul 20, 2020
@ishank011 ishank011 deleted the webdav-refs branch July 24, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants