Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on how to deploy reva together with the wopiserver locally #922

Merged
merged 4 commits into from
Jul 16, 2020

Conversation

LovisaLugnegard
Copy link
Contributor

Local setup for wopiserver and reva.

@labkode
Copy link
Member

labkode commented Jul 1, 2020

@LovisaLugnegard for installing reva, please point to: https://reva.link/docs/getting-started/install-reva/

There are others sections of the documentation that also define build steps, can you also update them to point to that link?

@LovisaLugnegard
Copy link
Contributor Author

LovisaLugnegard commented Jul 2, 2020

@labkode Since it's only two lines make deps and make build/make, I don't think it's worth the pain for the user reading the doc to open up a new tab. (When I'm reading documentation I prefer to have as much as possible in one place.)

@labkode
Copy link
Member

labkode commented Jul 2, 2020

@LovisaLugnegard isn't a matter of two lines, is a matter on how to best deploy Reva, and that is not by compiling it but to install it following the official installation guide.

@LovisaLugnegard
Copy link
Contributor Author

@labkode I think I'm missing some pieces, to me it looks like the instructions in "install reva" is not much more, but please tell me where I can find more information about this so I can point to a more specific url.
Screenshot 2020-07-02 at 14 26 38
Screenshot 2020-07-02 at 14 27 37

@labkode
Copy link
Member

labkode commented Jul 2, 2020

@LovisaLugnegard from the documentation you're preparing you need to point to: https://reva.link/docs/getting-started/install-reva/, is the first screenshot you have posted. The preferred way to install Reva is to download the binary directly and not to compile from sources.

Also, copy pasting build instructions in many places is not desirable, as you need to keep track of all of them.

@LovisaLugnegard
Copy link
Contributor Author

@labkode Firstly, I agree the doc shouldn't be replicated. I still don't fully agree with you though, mainly because one reason to have a local setup of reva and wopi is local development and testing, and then compiling is needed anyway - which is more or less two lines.
But it seems like you've stronger feelings about this than I've :)

@labkode labkode merged commit 78953c2 into cs3org:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants