Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New observability + general refactor of http/grpc clients #4166

Merged
merged 30 commits into from
Oct 10, 2023
Merged

New observability + general refactor of http/grpc clients #4166

merged 30 commits into from
Oct 10, 2023

Conversation

labkode
Copy link
Member

@labkode labkode commented Sep 6, 2023 •
edited
Loading

This PR:

  • adds possibility to register prometheus collectors from any package and expose them thorough a metrics endpoint
  • refactors packages dealing with context into just one appctx
  • refactors usage of http.DefaultClient to custom client that will propagate tokens and trace ID

@update-docs
Copy link

update-docs bot commented Sep 6, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@labkode labkode marked this pull request as ready for review September 27, 2023 13:12
@labkode labkode changed the title [WIP] New observability New observability + general refactor of http/grpc clients Sep 27, 2023
gmgigi96
gmgigi96 requested changes Oct 10, 2023
View reviewed changes
pkg/cbox/share/sql/sql.go Outdated Show resolved Hide resolved
pkg/cbox/storage/eoshomewrapper/eoshomewrapper.go Outdated Show resolved Hide resolved
pkg/cbox/storage/eoswrapper/eoswrapper.go Outdated Show resolved Hide resolved
labkode
labkode commented Oct 10, 2023
View reviewed changes
Copy link
Member Author

@labkode labkode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done + added tests

@gmgigi96 gmgigi96 merged commit 084c1b5 into cs3org:master Oct 10, 2023
23 checks passed
@labkode labkode deleted the new-observability branch October 11, 2023 10:29
@javfg javfg mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmgigi96 gmgigi96 gmgigi96 approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkode @gmgigi96