Log upload errors #4099
Closed
Log upload errors #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wrongly passed err to errors.Wrapf instead of err1, leading to a nil error to be returned.
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
kobergj
approved these changes
Aug 4, 2023
|
I can confirm that it now logs an error on failing upload. |
|
Don't we also need a log for the async upload case? Or is this covered already? |
|
@kobergj in the async-uploads case the errors are logged at https://github.com/cs3org/reva/blob/edge/pkg/storage/utils/decomposedfs/decomposedfs.go#L271 already. |
aduffeck
force-pushed
the
log-upload-errors
branch
from
b499a10
to
da7cbf2
Compare
aduffeck
force-pushed
the
log-upload-errors
branch
from
da7cbf2
to
d473410
Compare
|
Superseded by #4100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed a problem where problems with uploading blobs to the blobstore weren't logged.
Fixes owncloud/ocis#6962