Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle target in OpenInApp response #4077

Merged
merged 9 commits into from
Aug 3, 2023
Merged

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Jul 24, 2023

This PR adds the OpenInApp.target and AppProviderInfo.action properties to the respective responses (from /app/open and /app/list), to support different app integrations. Builds on top of cs3org/cs3apis#212.

In addition, the archiver was extended to use the name of the file/folder as opposed to download, and to include a query parameter to override the archive type, as it will be used in an upcoming app, see #4084.

@update-docs
Copy link

update-docs bot commented Jul 24, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@glpatcern glpatcern marked this pull request as draft July 24, 2023 15:17
@glpatcern glpatcern force-pushed the openappintab branch 2 times, most recently from a121198 to 3e9a8c3 Compare July 26, 2023 15:35
@labkode
Copy link
Member

labkode commented Jul 27, 2023

Rebase needed

@glpatcern glpatcern marked this pull request as ready for review July 27, 2023 12:34
@glpatcern glpatcern requested a review from a team as a code owner July 27, 2023 12:34
@glpatcern glpatcern force-pushed the openappintab branch 3 times, most recently from 8ddfedb to 40d26e8 Compare July 28, 2023 16:23
@glpatcern glpatcern force-pushed the openappintab branch 4 times, most recently from 72a768f to 1305127 Compare August 1, 2023 15:13
@labkode
Copy link
Member

labkode commented Aug 3, 2023

Breaking change:
Default changes from "download_archive" http prefix to "archiver".

@labkode labkode merged commit 9266d8e into cs3org:master Aug 3, 2023
23 checks passed
glpatcern added a commit to cernbox/reva that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants