fixed couple of smaller space lookup issues #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
rhafer
changed the title
aduffeck
reviewed
Jun 15, 2023
| @@ -164,7 +164,7 @@ func Pathify(id string, depth, width int) string { | |||
|
|
|||
| // NodeFromSpaceID converts a resource id without an opaque id into a Node | |||
| func (lu *Lookup) NodeFromSpaceID(ctx context.Context, id *provider.ResourceId) (n *node.Node, err error) { | |||
| node, err := node.ReadNode(ctx, lu, id.SpaceId, id.OpaqueId, false, nil, false) | |||
| node, err := node.ReadNode(ctx, lu, id.SpaceId, id.SpaceId, false, nil, false) | |||
There was a problem hiding this comment.
The change itself looks good to me, but how about changing the signature of NodeFromSpaceID to
func (lu *Lookup) NodeFromSpaceID(ctx context.Context, spaceID string) (n *node.Node, err error)
while we're at it to better reflect what's going on?
The current signature poses the risk that it's gonna be used wrongly in the future when people shove in a resource ID and expect the opaque id to be considered.
Pass the correct ID (the spaced id) to ReadNode(). Also fix the signature of the NodeFromSpaceID method to make it more obvious that just needs a Resource ID.
ListFolder passed the wrong node for the SpaceRoot parameter to ReadNode()
aduffeck
approved these changes
Jun 15, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Jun 20, 2023
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ListFolder to have the correct SpaceRoot in the results
ListFolder passed the wrong node for the SpaceRoot parameter to ReadNode()
also:
Fix ReadNode call in NodeFromSpaceID()
Pass the correct ID (the spaced id) to ReadNode().