Implement historical way of constructing OCM WebDAV URL #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
webdav_ocm_compliant
branch
2 times, most recently
from
e2d2dd8
to
0e596be
Compare
gmgigi96
commented
May 10, 2023
|
@glpatcern can you update the ocmd example adding the new service please? |
gmgigi96
commented
May 10, 2023
glpatcern
force-pushed
the
webdav_ocm_compliant
branch
from
16dacc7
to
0496332
Compare
gmgigi96
commented
May 10, 2023
gmgigi96
commented
May 10, 2023
glpatcern
force-pushed
the
webdav_ocm_compliant
branch
2 times, most recently
from
00dd78f
to
6cac20f
Compare
glpatcern
requested changes
May 11, 2023
There was a problem hiding this comment.
OK, I tested my part and it's all fine, and I understand that Michiel successfully used the webdav access part, so we are good to go.
The cosmetic changes I propose are just to acknowledge that these are not temporary "fixes" and are there to stay potentially for a long time - at least until there's a OC10 site in ScienceMesh, and NC implements OCM v1.1.
glpatcern
force-pushed
the
webdav_ocm_compliant
branch
from
6bbbb70
to
b0504d9
Compare
This reverts commit 1ecb6e4.
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
gmgigi96
force-pushed
the
webdav_ocm_compliant
branch
from
541a024
to
8b5d251
Compare
glpatcern
previously approved these changes
May 11, 2023
gmgigi96
force-pushed
the
webdav_ocm_compliant
branch
from
cd6acc4
to
8b5d251
Compare
gmgigi96
force-pushed
the
webdav_ocm_compliant
branch
from
df8a753
to
ca75c78
Compare
glpatcern
approved these changes
May 11, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
* adapt webdav ocm endpoint according to historical way of contructing webdav url * add discovery endpoint in the ocm client * Make root OCM URLs configurable in /ocm-provider * add changelog * fix path for old ocm webdav * Added reverse proxy for /ocm-provider * Revert "Added reverse proxy for /ocm-provider" This reverts commit 1ecb6e4. * Moved ocm-provider to a new http service * Updated examples * Linting * Simplified ocmprovider and documented config * Further simplification + relaunching the CI * Regenerated docs * Expose OCM as disabled if no endpoint is configured for it * Update internal/http/services/owncloud/ocdav/propfind.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/dav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/dav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/ocdav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/propfind.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * fix support legacy ocm access --------- Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* adapt webdav ocm endpoint according to historical way of contructing webdav url * add discovery endpoint in the ocm client * Make root OCM URLs configurable in /ocm-provider * add changelog * fix path for old ocm webdav * Added reverse proxy for /ocm-provider * Revert "Added reverse proxy for /ocm-provider" This reverts commit 1ecb6e4. * Moved ocm-provider to a new http service * Updated examples * Linting * Simplified ocmprovider and documented config * Further simplification + relaunching the CI * Regenerated docs * Expose OCM as disabled if no endpoint is configured for it * Update internal/http/services/owncloud/ocdav/propfind.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/dav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/dav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/ocdav.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/owncloud/ocdav/propfind.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * fix support legacy ocm access --------- Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the expected WebDAV endpoint for OCM by OC10 and Nextcloud as described in cs3org/OCM-API#70 (comment) to allow Reva providers to participate to ScienceMesh.
In addition, expose the OCM discovery endpoint as
/ocm-providerat the root level.Closes #3855