Implemented folderurl for WOPI apps #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
requested review from
labkode,
wkloucek and
gmgigi96
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
folderurl-for-apps
branch
from
8f11f01
to
9cc1698
Compare
glpatcern
force-pushed
the
folderurl-for-apps
branch
from
9cc1698
to
6e1ece3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
glpatcern
force-pushed
the
folderurl-for-apps
branch
4 times, most recently
from
f232b14
to
c9d4939
Compare
glpatcern
added a commit
to cs3org/wopiserver
that referenced
this pull request
Nov 30, 2022
glpatcern
force-pushed
the
folderurl-for-apps
branch
2 times, most recently
from
bd1a15e
to
9fb6bc4
Compare
glpatcern
force-pushed
the
folderurl-for-apps
branch
from
9fb6bc4
to
a3eece7
Compare
glpatcern
force-pushed
the
folderurl-for-apps
branch
from
a3eece7
to
416c25e
Compare
gmgigi96
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folderurl is now populated for WOPI apps, such that for owners and named shares it points to the containing folder, and for public links it points to the appropriate public link URL.
On the way, functions to manipulate the user's scope and extract the eventual public link token(s) have been added, coauthored with @gmgigi96.
The logic here is slightly different from what was implemented in the edge branch (cf. #3291) as the configurable folder base URL is not templated.