Configurable MaxLockCycles #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
MaxAcuireLockCycles
branch
from
381d011
to
11069bb
Compare
|
@kobergj codacy is not happy with the Changelog markdown |
|
It is. I fixed the issue already, it's just still shown in red because the pipeline is red. |
fschade
approved these changes
Nov 3, 2022
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
is this still needed, now that we debounce for a longer time? in the experimental branch @fschade still see the 500 errors in clients, which he can fix by crinking up this ... or was that only the case on edge? |
micbar
reviewed
Nov 3, 2022
| When a file is locked the flock library will retry a given amount of times (with a increasing sleep time inbetween each round) | ||
| Until now the max amount of such rounds was hardcoded to `10`. Now it is configurable, falling back to a default of `25` | ||
|
|
||
| https://github.com/owncloud/ocis/pull/4959 |
There was a problem hiding this comment.
@kobergj this changelog entry is broken. We need the reva pull request in the first line of the link list because it provides the primary issue id which needs to resolve inside the repo.
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file is locked the flock library will retry a given amount of times (with a increasing sleep time inbetween each round)
Until now the max amount of such rounds was hardcoded to
10. Now it is configurable, falling back to a default of25