Improve lock contention #3395
Merged
Improve lock contention #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now try to list the extended attributes without grabbing a read lock at first. Only if that fails (e.g. due to concurrent writes to the xattrs) we read again while holding a read lock.
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
aduffeck
force-pushed
the
improve-lock-contention
branch
from
07de804
to
4ca07ed
Compare
C0rby
approved these changes
Oct 26, 2022
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces lock contention during high load by optimistically non-locking when listing the extended attributes of a file.
Only in case of issues the list is read again while holding a lock.
Fixes owncloud/ocis#4879