Backport from edge: added support for language locales in apps #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
requested review from
labkode,
wkloucek and
ishank011
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
lang-supp-in-app
branch
from
ac7bb64
to
85d419e
Compare
glpatcern
force-pushed
the
lang-supp-in-app
branch
from
85d419e
to
f4d69fb
Compare
glpatcern
force-pushed
the
lang-supp-in-app
branch
3 times, most recently
from
02bd43c
to
f979ea4
Compare
glpatcern
force-pushed
the
lang-supp-in-app
branch
2 times, most recently
from
211f85a
to
e155d9d
Compare
glpatcern
force-pushed
the
lang-supp-in-app
branch
from
e155d9d
to
1aefcf6
Compare
glpatcern
force-pushed
the
lang-supp-in-app
branch
from
1aefcf6
to
cbf25a7
Compare
labkode
approved these changes
Oct 6, 2022
|
@micbar as you authored #3291 you may want to see a different flavor for it:
|
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Oct 18, 2022
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Oct 18, 2022
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Oct 20, 2022
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to backport the minimal logic from
edgeto support different locales in WOPI apps, and drive this by configuration rather than by query parameters.In addition, the
DC_LLCCparameter should be used for Office 365 to compensate issues with incorrect dates computations depending on the locale:https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/online/discovery#dc_llcc