Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactors logger to have ctx [Go Hack] #2841

Merged
merged 2 commits into from
May 12, 2022

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented May 9, 2022

Signed-off-by: afzal442 afzal442@gmail.com

Fixes: #2640

Signed-off-by: afzal442 <afzal442@gmail.com>
@afzal442 afzal442 changed the title Fix: refactors logger to have ctx fix: refactors logger to have ctx May 9, 2022
micbar
micbar previously approved these changes May 9, 2022
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbar
Copy link
Member

micbar commented May 9, 2022

please add a changelog file to make CI pass

Signed-off-by: afzal442 <afzal442@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cs3org cs3org deleted a comment from update-docs bot May 9, 2022
@labkode labkode merged commit c082028 into cs3org:master May 12, 2022
@afzal442 afzal442 deleted the refactor/logger/bugbash branch May 12, 2022 16:20
@afzal442 afzal442 changed the title fix: refactors logger to have ctx fix: refactors logger to have ctx [Go Hack] May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix static logging issues
4 participants