Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix static registry lookups #2750

Closed
wants to merge 46 commits into from
Closed

fix static registry lookups #2750

wants to merge 46 commits into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Apr 19, 2022

@butonic
fix statil registry lookups
89a3a6b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@update-docs
Copy link

update-docs bot commented Apr 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the title fix statil registry lookups fix static registry lookups Apr 19, 2022
kobergj and others added 27 commits April 19, 2022 15:10
@kobergj
adjust path in prpfind handler
d0ce26e 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
unwrap providerid if possible
5c6619e 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add unit tests and fix old ones
993c7f3 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
avoid data race and start spreading the providerID
ceeae0a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
make mountid configurable
12de4ae 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
Merge branch 'edge' into use-static-registry
c8a9fa1
@kobergj
hack around in static registry
a1b3b65 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
stat spaces from gateway
08f096a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
fix the unit tests
15368e4 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
preserve backwardscompatability
a5ecaf7 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
findAllProviders for static registry
0e63526 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
more hacking
1c1dfb8 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
more hacking - but makes upload work
4171fe4 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
refactor static GetProvider
4d10076 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
play with drone configuration
ece8731 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
Merge branch 'edge' into use-static-registry
37acc94
@kobergj
repair public links
6eb97d1 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
helperfunc to read json from opaque
fdd96ff 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
more config changes
26d787f 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
play with ci pipeline
8f2abf3
@kobergj
even more hacking
0689582 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
fix makeRelativeReference
cabf010 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@butonic
fix path propfind for children
2175f6b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
use static registry in gateway.toml
9271be8 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix user storage provider port in gateway.toml
fd4b7b0 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix gateway.toml
36818ae 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix gateway.toml home_provider
0ff36da 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the use-static-registry branch 3 times, most recently from adf7136 to caf4dd8 Compare April 26, 2022 13:16
@butonic
prefix storageproviderid for litmus
ba5045e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
kobergj and others added 7 commits April 26, 2022 17:37
@kobergj
pass the path to decomposedfs
3a0d70f 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@butonic
fix GetPath
40d501b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
start storageproviderid middleware
f6ae63a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add storageproviderid interceptor
a364d01 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@kobergj
complete storageproviderid middleware
216f0dc 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
don't unwrap storageid in decomposedfs
ae15011 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
avoid panics in storageid interceptor
349cab7 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging 349cab7 into 618964e - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging 9400cd2 into 618964e - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@kobergj
get rid of interceptor and move logic to storageprovider
e15f4a1 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging e15f4a1 into 618964e - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@kobergj
use configured mountID instead of requested one
27ad90f 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
use requested providerID for Stat calls
2274dbd 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging 2274dbd into bfdfc83 - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@kobergj
storageid unwrap for sharesstorageprovider
7b9611a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
storageid unwrap for publicstorageprovider
04d7c66 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging 04d7c66 into 8ff0830 - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@kobergj
fallback to providerid if empty
e96aa17 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging e96aa17 into 8ff0830 - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@butonic
use regex to route share requests to the sharesstorageprovider
baafc52 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging baafc52 into 8ff0830 - view on LGTM.com

fixed alerts:

  • 3 for Uncontrolled data used in path expression

@ishank011
Copy link
Contributor

Hi @butonic @kobergj what's the progress on this one? Could I give you a hand?

@kobergj
Copy link
Contributor

kobergj commented May 3, 2022

@ishank011 we have gone another approach to make it until beta. We are trying to include the benefits of the static registry into the spaces registry.

We introduced storageproviderid prefixing with this PR: #2790
And we will improve registry performance for ID based requests with this PR: #2792

Eventually there will be another branch improving performance on path based registry requests.

@butonic butonic closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode labkode will be requested when the pull request is marked ready for review labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern will be requested when the pull request is marked ready for review glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @ishank011 @kobergj