Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates Makefile #2747

Merged
merged 2 commits into from
Apr 19, 2022
Merged

fix: Updates Makefile #2747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d113374
fix: Updates Makefile
KarthikSundar2002 Apr 19, 2022
968c0cc
Adds Changelog
KarthikSundar2002 Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ test-go-version:
# for manual building only
deps:
cd /tmp && rm -rf golangci-lint && git clone --quiet -b 'v1.42.1' --single-branch --depth 1 https://github.com/golangci/golangci-lint &> /dev/null && cd golangci-lint/cmd/golangci-lint && go install
cd /tmp && go get golang.org/x/tools/cmd/goimports
cd /tmp && go install golang.org/x/tools/cmd/goimports@latest

build-ci: off
go build -ldflags ${CI_BUILD_FLAGS} -o ./cmd/revad/revad ./cmd/revad
Expand Down
7 changes: 7 additions & 0 deletions changelog/unreleased/update-makefile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Updates Makefile according to latest go standards

Earlier, we were using go get to install packages.
Now, we are using go install to install packages

https://github.com/cs3org/reva/issues/2675
https://github.com/cs3org/reva/pull/2747