Merge oidcmapping auth manager into oidc #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
unify-oidc
branch
2 times, most recently
from
dc354d1
to
a7f1cea
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
unify-oidc
branch
from
a7f1cea
to
71eda4e
Compare
|
This pull request fixes 1 alert when merging 6e370df into 812d9e6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 6967f1d into 812d9e6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 169d714 into 2f8da47 - view on LGTM.com fixed alerts:
|
ishank011
approved these changes
Apr 12, 2022
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2007: the mapping feature for the OIDC auth provider was already factored out, therefore this PR removes code duplication and ensures more coherence.
Compared to the pre-existing OIDC code, the new code:
issas opposed toissuer)preferred_usernameandemailclaims