Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer exception when resolving members of a group (rest driver) #2265

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix nil pointer exception when resolving members of a group (rest driver) #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b29ffa3
Fix nil pointer exception when resolving members of a group
gmgigi96 Nov 11, 2021
3447b0c
Add changelog
gmgigi96 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/fix-nil-exception-groups.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: Fix nil pointer exception when resolving members of a group (rest driver)

https://github.com/cs3org/reva/pull/2265
4 changes: 3 additions & 1 deletion pkg/cbox/group/rest/rest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,9 @@ func (m *manager) GetMembers(ctx context.Context, gid *grouppb.GroupId) ([]*user
if !ok {
return nil, errors.New("rest: error in type assertion")
}
users = append(users, &userpb.UserId{OpaqueId: userInfo["upn"].(string), Idp: m.conf.IDProvider})
if id, ok := userInfo["upn"].(string); ok {
users = append(users, &userpb.UserId{OpaqueId: id, Idp: m.conf.IDProvider})
}
}

if err = m.cacheGroupMembers(gid, users); err != nil {
Expand Down