Fix unset xattr on darwin #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
force-pushed
the
fixes-cleanup
branch
from
8788d6e
to
125427d
Compare
|
@C0rby can you confirm and test on linux? |
dragotin
reviewed
Nov 11, 2021
|
@micbar how can I test this? Do you have an example request? |
The errors did happen during startup. So a simple startup of ocis should be sufficient. |
|
I don't see any errors during startup on linux. 👍 |
dragotin
previously approved these changes
Nov 11, 2021
micbar
force-pushed
the
fixes-cleanup
branch
from
b6bf78f
to
3a5661b
Compare
ishank011
approved these changes
Nov 11, 2021
refs
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Bugfixes
Empty Xattr for quota was creating error logs only on darwin
ENODATAerror code isENOATTRon darwinBefore
{"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"} {"level":"error","service":"storage","pkg":"rgrpc","error":"xattr.get /Users/mbarz/.ocis/storage/metadata/nodes/root user.ocis.quota: attribute not found","nodepath":"/Users/mbarz/.ocis/storage/metadata/nodes/root","time":"2021-11-10T22:02:26+01:00","message":"could not read quota"}2 Propfind with invalid depth did not return a body