Fix opening a readonly filetype with WOPI #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pports viewing the filetype
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
changed the title
glpatcern
previously approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Looks good, and also in line with the discussion in cs3org/cs3apis#145.
Just fix the reference in the changelog (2073 instead of 2051), and once the above PR is included we can also expose the capability for such cases where only a viewURL exists.
labkode
reviewed
Sep 16, 2021
glpatcern
previously approved these changes
Sep 23, 2021
ishank011
reviewed
Sep 23, 2021
ishank011
approved these changes
Sep 27, 2021
glpatcern
pushed a commit
to glpatcern/reva
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eg. JPG or PNG are supported to be opened by Collabora - but in view mode only. "/app/open" request currently fails because the WOPI driver assuems that an edit vie mode always exists.