Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix versions order in propfind response #1911

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix versions order in propfind response #1911

merged 1 commit into from
Jul 23, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jul 22, 2021

The order of the file versions in propfind responses was incorrect.

@C0rby C0rby force-pushed the sort-versions branch 2 times, most recently from c4789f4 to e76414d Compare July 22, 2021 13:02
@C0rby C0rby marked this pull request as ready for review July 22, 2021 13:02
@C0rby C0rby requested a review from labkode as a code owner July 22, 2021 13:02
@C0rby C0rby requested review from butonic and ishank011 July 22, 2021 13:02
@C0rby C0rby mentioned this pull request Jul 22, 2021
Closed
@ishank011
Copy link
Contributor

@C0rby can we do it in the storageprovider service?

@C0rby
Copy link
Contributor Author

C0rby commented Jul 23, 2021

Sure, I moved it to the storage provider. 👍

@ishank011 ishank011 merged commit adceeb2 into cs3org:master Jul 23, 2021
@C0rby C0rby deleted the sort-versions branch July 23, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @ishank011